Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test on Python 3.12 #683

Merged
merged 4 commits into from
Sep 15, 2023
Merged

Test on Python 3.12 #683

merged 4 commits into from
Sep 15, 2023

Conversation

jarrodmillman
Copy link
Contributor

No description provided.

@jarrodmillman jarrodmillman marked this pull request as draft September 8, 2023 17:45
@rgommers
Copy link
Member

rgommers commented Sep 8, 2023

To pick up the right numpy pre-release version, see numpy/numpy#23808 (comment) and PIP_PRE a few comments up from that.

@Avasam Avasam mentioned this pull request Sep 8, 2023
Merged
@jarrodmillman
Copy link
Contributor Author

The PIP_FLAGS variable wasn't being used. Setting CIBW_ENVIRONMENT didn't work. I also don't think the comment about 'numpy>=1.26.0b1; python_version>="3.12.0.rc1"', is true. Most of the other projects including scipy and pandas are using "numpy>=1.26.0b1; python_version>='3.12'", which seems to work fine in all the projects. If you see an instance where that doesn't work, let me know.

@jarrodmillman jarrodmillman marked this pull request as ready for review September 11, 2023 19:54
@jarrodmillman
Copy link
Contributor Author

See matplotlib/matplotlib#26736. Also you may want to look at my comments about the version numbering. I suspect other projects are likely to be using the wrong numbering scheme, since I've seen other projects do similar things.

@jarrodmillman
Copy link
Contributor Author

They are planning matplotlib 3.8 final release this week. That should simplify this PR, so we may want to wait for that release. But I am also happy merging this now and fixing things later.

@rgommers
Copy link
Member

Most of the other projects including scipy and pandas are using "numpy>=1.26.0b1; python_version>='3.12'", which seems to work fine in all the projects.

Hmm, I thought it wouldn't - but maybe tools have special-cased Python version numbers now in a way that deviates from PEP 440 for convenience. If so, great - fewer things to tweak.

That should simplify this PR, so we may want to wait for that release. But I am also happy merging this now and fixing things later.

If you need a final release of pywavelets now to make life easier for scikit-image & co, then we can merge this now. Otherwise, maybe easier to wait? No strong preference from me.

@jarrodmillman jarrodmillman mentioned this pull request Sep 12, 2023
Closed
@jarrodmillman
Copy link
Contributor Author

Let's give it a few days and see how things progress. It would be good to have a pywt release early next week. I have a few more cleanup PRs I would like to make, so maybe we can get those in as well.

@rgommers
Copy link
Member

I'm on holiday next week, so if you need it soon it may be useful to do the release by Friday. @grlee77 is that fine with you? Anything you'd like to get in?

@jarrodmillman jarrodmillman mentioned this pull request Sep 14, 2023
Closed
@rgommers rgommers added this to the v1.5.0 milestone Sep 15, 2023
rgommers
rgommers approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all LGTM, works as advertised as far as I can tell. In it goes, thanks @jarrodmillman. And thanks for the review @cclauss.

@rgommers rgommers merged commit 74e0cc1 into PyWavelets:master Sep 15, 2023
14 checks passed
@rgommers
Copy link
Member

The numpy 1.26.0 release will be out today if things go as planned, so let's hold off on modifying the wheel build jobs to deal with pre-releases.

@jarrodmillman jarrodmillman deleted the py312 branch March 13, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jarrodmillman @rgommers @cclauss