Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/big dipper image issue #2469

Merged
merged 4 commits into from
Jul 28, 2024
Merged

Fix/big dipper image issue #2469

merged 4 commits into from
Jul 28, 2024

Conversation

Raviramnani1
Copy link
Collaborator

@Raviramnani1 Raviramnani1 commented Jul 27, 2024

Description

To fix the issue of image loading on wallet.pylons.tech buy page

upgrade Next.js codemod for next-image-to-legacy-image

updated ipfsDomain to proxy.pylons.tech in easel/constants and wallet/constants because of slow loading on ipfs.io

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link
Collaborator

@girishramnani girishramnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets fix a few of the “unused-parameter” warnings

@MikeSofaer MikeSofaer merged commit e23082c into main Jul 28, 2024
20 of 26 checks passed
@MikeSofaer MikeSofaer deleted the fix/big-dipper-image-issue branch July 28, 2024 10:15
@zube zube bot removed the [zube]: Done label Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants