support existing projects #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonOstrez
reviewed
Jun 4, 2024
| f"Please copy your project files to {project_root} and press Continue", | ||
| allow_empty=False, | ||
| buttons={ | ||
| "continue": "Continue", |
There was a problem hiding this comment.
We should have Back button also
| imported_lines = sum(len(f.content.content.splitlines()) for f in imported_files) | ||
| if imported_lines > MAX_PROJECT_LINES: | ||
| await self.send_message( | ||
| "WARNING: Your project ({imported_lines} LOC) is larger than supported and may cause issues in Pythagora." |
There was a problem hiding this comment.
If i understand this correctly we don't really block users from loading bigger projects, we just show the warning. I think warning is not enough and we should check LOC before importing files and then fail importing if it is bigger project
|
|
||
| spec = self.current_state.specification.clone() | ||
| spec.description = llm_response | ||
| self.next_state.specification = spec |
There was a problem hiding this comment.
Should we maybe also get architecture, sys dependencies and package dependencies?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds EXPERIMENTAL support for importing existing projects.
Demo
2024-05-29-08-36.mp4