-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade precommit librairies and add to CI #112
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
If you remove pre-commit config, nothing will be done. The Github app is just an integration to auto run and commit the fixes defined in the config file. |
Remove lambdas and fix pep8 checks
for more information, see https://pre-commit.ci
I had the impression to have twice the workflows? As I seen now I only have one and it seems to have done what was expected. What am I missing here? Do we miss such a workflow in the TEKSI/wastewater repository? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah sorry, I just read that you were removing "precommit yaml" and understood you were talking about the config file instead of the Github workflow.
Indeed no need for the workflow, you have a "ci" section in the config and pre-commit.ci is connected to this repo, so all good!
Add the precommit GitHub APP and workflow, with equivalent rules as we have in the new TEKSI wastewater repository.