Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade precommit librairies and add to CI #112

Merged
merged 6 commits into from
Sep 26, 2024
Merged

Conversation

ponceta
Copy link
Member

@ponceta ponceta commented Sep 25, 2024

Add the precommit GitHub APP and workflow, with equivalent rules as we have in the new TEKSI wastewater repository.

@3nids
Copy link
Member

3nids commented Sep 25, 2024

If you remove pre-commit config, nothing will be done. The Github app is just an integration to auto run and commit the fixes defined in the config file.

@ponceta
Copy link
Member Author

ponceta commented Sep 25, 2024

If you remove pre-commit config, nothing will be done. The Github app is just an integration to auto run and commit the fixes defined in the config file.

I had the impression to have twice the workflows? As I seen now I only have one and it seems to have done what was expected. What am I missing here? Do we miss such a workflow in the TEKSI/wastewater repository?

@ponceta ponceta requested a review from 3nids September 25, 2024 09:47
Copy link
Member

@3nids 3nids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah sorry, I just read that you were removing "precommit yaml" and understood you were talking about the config file instead of the Github workflow.

Indeed no need for the workflow, you have a "ci" section in the config and pre-commit.ci is connected to this repo, so all good!

@ponceta ponceta merged commit e3d1540 into master Sep 26, 2024
3 checks passed
@ponceta ponceta deleted the poa_precommit_ci branch September 26, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants