Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more efficient proximal total variation operator #10

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

dpshepherd
Copy link
Contributor

Implement TV operator found in: Kamilov, Ulugbek S. "A parallel proximal algorithm for anisotropic total variation minimization." IEEE Transactions on Image Processing 26.2 (2016): 539-548.

@dpshepherd dpshepherd added the enhancement New feature or request label Nov 30, 2024
@dpshepherd
Copy link
Contributor Author

@ptbrown1729 - I wasn't sure if you want this to live in it's own file or fold it into optimize.py. What do you prefer?

I have some questions about this approach still, but given that it is non-iterative, I think it is worth a shot to try. If it doesn't work, we can try out the other "fast" approach I mentioned via email.

@ptbrown1729
Copy link
Collaborator

@dpshepherd since it doesn't add any new dependencies and we don't have that many proximal operators, I am fine if it lives in optimize.py. And we can collapse shrinkage() and the optimize.py function soft_threshold(), since these should be the same function

@dpshepherd
Copy link
Contributor Author

Perfect, I made those changes. I can test this coming week.

@dpshepherd
Copy link
Contributor Author

That commit is from me, I hadn't changed accounts on the ODT/SIM computer yet. Should be fixed now.

@dpshepherd dpshepherd changed the base branch from master to dev December 11, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants