Fix Windows Release publishing. #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use powershell multi-line command separators (backticks) for long command line call.
|
Oh wow! I did have those backticks, but I removed them, since I thought they are an artifact of Appveyor syntax. Thank you for catching this! Not sure why it is failing now.... We also should look (at some point) how to disable package generation and upload when the workflow is triggered on PR. |
|
I suspect that windows build above fails since the secret.GA_TOKEN is probably not accessible from my pull request (see also same error on Linux build for this PR). I tried on my own repo with my own token and it seems to be fine in general. |
|
I am merging this one, since overall PRs do not need to be generating packages, so we can ignore those errors for now I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use powershell multi-line command separators (backticks) for long command line call.