Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to merge changes from dev to pass EXPOsan tests #108

Merged
merged 9 commits into from
Oct 3, 2023
Merged

Need to merge changes from dev to pass EXPOsan tests #108

merged 9 commits into from
Oct 3, 2023

Conversation

joyxyz1994
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #108 (89f2cd8) into main (8d69baf) will increase coverage by 0.77%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   74.69%   75.46%   +0.77%     
==========================================
  Files          93       90       -3     
  Lines       16031    15705     -326     
  Branches     1697     1675      -22     
==========================================
- Hits        11974    11852     -122     
+ Misses       3583     3379     -204     
  Partials      474      474              
Flag Coverage Δ
unittests 75.46% <100.00%> (+0.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
qsdsan/equipments/__init__.py 100.00% <ø> (ø)
qsdsan/equipments/_membrane.py 100.00% <100.00%> (+43.75%) ⬆️
qsdsan/processes/_adm1.py 80.25% <100.00%> (+0.08%) ⬆️
qsdsan/sanunits/__init__.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@yalinli2 yalinli2 merged commit 946bf48 into main Oct 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants