-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to allow customized properties and impact item creation #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #109 +/- ##
==========================================
- Coverage 75.46% 73.90% -1.57%
==========================================
Files 90 91 +1
Lines 15705 16003 +298
Branches 1675 1688 +13
==========================================
- Hits 11852 11827 -25
- Misses 3379 3704 +325
+ Partials 474 472 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
A note that once the |
I added a test file for the METAB systems on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are minor, but since they are to the basic classes so I wanted to make sure I'm not messing things up. One is to add a dictionary in
WasteStream
(addtional_properties
) so that users can throw in whatever properties they want, like turbidity, etc.Another is to allow the creation of
StreamImpactItem
through theload_from_file
function, this way you can put all CFs together in one spreadsheet.All the tests are passing locally, but I realized
metab
doesn't have a test file, so just want to make sure the updates aren't breaking your stuff @joyxyz1994 , thanks!