Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sanunits for the htl system #115

Merged
merged 13 commits into from
Nov 17, 2023
Merged

update sanunits for the htl system #115

merged 13 commits into from
Nov 17, 2023

Conversation

jiananf2
Copy link
Contributor

sanunits used in the htl system have been updated. Another pull request has been made in exposan.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (d8965d1) 74.35% compared to head (6a93428) 74.11%.

Files Patch % Lines
qsdsan/sanunits/_hydrothermal.py 87.09% 3 Missing and 1 partial ⚠️
qsdsan/sanunits/_hydroprocessing.py 83.33% 1 Missing ⚠️
qsdsan/sanunits/_reactor.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   74.35%   74.11%   -0.24%     
==========================================
  Files          91       91              
  Lines       16016    16026      +10     
  Branches     1688     1686       -2     
==========================================
- Hits        11908    11878      -30     
- Misses       3650     3691      +41     
+ Partials      458      457       -1     
Flag Coverage Δ
unittests 74.11% <86.66%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yalinli2 yalinli2 merged commit 6a93428 into main Nov 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants