Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #122

Merged
merged 10 commits into from
May 8, 2024
Merged

Dev #122

merged 10 commits into from
May 8, 2024

Conversation

joyxyz1994
Copy link
Member

No description provided.

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 14 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@e220748). Click here to learn what that means.

Files Patch % Lines
qsdsan/_process.py 27.27% 8 Missing ⚠️
qsdsan/sanunits/_anaerobic_reactor.py 50.00% 3 Missing and 1 partial ⚠️
qsdsan/sanunits/_suspended_growth_bioreactor.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #122   +/-   ##
=======================================
  Coverage        ?   74.18%           
=======================================
  Files           ?       91           
  Lines           ?    16053           
  Branches        ?     1693           
=======================================
  Hits            ?    11909           
  Misses          ?     3688           
  Partials        ?      456           
Flag Coverage Δ
unittests 74.18% <53.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yalinli2
Copy link
Member

yalinli2 commented May 8, 2024

I'll merge this in, I'm having issues with Codecov recently despite multiple tries to fix it... But since all the tests are passed here maybe it somehow has been fixed?

@yalinli2 yalinli2 merged commit ea32b82 into main May 8, 2024
6 checks passed
@yalinli2
Copy link
Member

yalinli2 commented May 8, 2024

Oh perfect Codecov fixed itself/you fixed Codecov 🎉 @joyxyz1994

@joyxyz1994
Copy link
Member Author

haha cool! I'm not sure what happened lol..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants