-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python Major Versions that can be used #80
base: master
Are you sure you want to change the base?
Conversation
see also AMLab-Amsterdam/lie_learn#26 |
as lie_learn currently cannot be installed with python 3.11 and above Signed-off-by: Peter Steinbach <p.steinbach@hzdr.de>
- added classifiers (not sure what they invoke on PyPI etc) - added python version limiter for lie_learn (needs to be tested) Signed-off-by: Peter Steinbach <p.steinbach@hzdr.de>
Signed-off-by: Peter Steinbach <p.steinbach@hzdr.de>
Note, I checked the installation of the package with py 3.7 and 3.11. The former works as expected, the latter bails out as python 3.11 is not supported currently. According to the docs, this change once pushed to PyPI should also affect people running |
I just noticed this PR, and I haven't looked at it too closely, but I don't think it makes sense for If anything, it might be possible for |
Good discussion! While being a bit blunt, I suggest this PR to prevent headaches for people lacking the capabilities to deal with the deficiencies of lie_learn. That is the core motivation. |
I agree with that motivation, but I worry that this approach will just shift the headaches to people who want to use up-to-date python. Especially since, if the goal is to avoid I'd prefer to either (i) do nothing and wait for
Not totally sure that that's the right syntax, but in principle that would immediately solve the problem, and it'd be easy to switch back to the real |
I just checked, @kalekundert suggestion works like a charm for a local |
as lie_learn currently cannot be installed with python 3.11 and above