Eagerly log output of regen-apis (#1910)

The script is quite slow, so it's better to log the output eagerly so it
doesn't look like things hung.

scripts/js/commands/api/regenerateApiDocs.ts

@@ -55,7 +55,6 @@ zxMain(async () => {
   const args = readArgs();
   await validateGitStatus();
 
-  const results = new Map<string, string[]>();
   for (const pkgName of Pkg.VALID_NAMES) {
     if (args.package && pkgName != args.package) {
       continue;
@@ -67,22 +66,15 @@ zxMain(async () => {
     );
     const maybeDevVersion = await getDevVersion(pkgName);
 
-    const result = await processVersions(
+    await processVersions(
       pkgName,
       args.skipDownload,
       historicalVersions,
       currentVersion,
       maybeDevVersion,
     );
-    results.set(pkgName, result);
   }
 
-  console.log("");
-  results.forEach((result: string[], pkgName: string) => {
-    console.log(`Regeneration of ${pkgName}:`);
-    result.forEach((msg) => console.error(msg));
-    console.log("");
-  });
   await generateHistoricalRedirects();
 
   console.log(`Each regenerated version has been saved as a distinct commit. If the changes are
@@ -96,37 +88,27 @@ async function processVersions(
   historicalVersions: string[],
   currentVersion: string,
   maybeDevVersion: string | undefined,
-): Promise<string[]> {
-  const results: string[] = [];
-
+): Promise<void> {
   for (const historicalVersion of historicalVersions) {
-    results.push(
-      await regenerateVersion(
-        pkgName,
-        historicalVersion,
-        skipDownload,
-        "historical",
-      ),
+    await regenerateVersion(
+      pkgName,
+      historicalVersion,
+      skipDownload,
+      "historical",
     );
   }
-
-  results.push(await regenerateVersion(pkgName, currentVersion, skipDownload));
-
+  await regenerateVersion(pkgName, currentVersion, skipDownload);
   if (maybeDevVersion) {
-    results.push(
-      await regenerateVersion(pkgName, maybeDevVersion, skipDownload, "dev"),
-    );
+    await regenerateVersion(pkgName, maybeDevVersion, skipDownload, "dev");
   }
-
-  return results;
 }
 
 async function regenerateVersion(
   pkgName: string,
   version: string,
   skipDownload: boolean,
   typeArgument?: "historical" | "dev",
-): Promise<string> {
+): Promise<void> {
   const command = ["npm", "run", "gen-api", "--", "-p", pkgName, "-v", version];
   if (typeArgument) {
     command.push(`--${typeArgument}`);
@@ -139,13 +121,13 @@ async function regenerateVersion(
     await $`${command}`;
     if ((await gitStatus()) !== "") {
       await gitCommit(`Regenerate ${pkgName} ${version}`);
-      return `✅ ${pkgName} ${version} regenerated correctly`;
+      console.log(`🚀 ${pkgName} ${version} regenerated correctly`);
     } else {
-      return `☑️ ${pkgName} ${version} is up-to-date`;
+      console.log(`✅ ${pkgName} ${version} is already up-to-date`);
     }
   } catch (_) {
     await gitRestore(".");
-    return `❌ ${pkgName} ${version} failed to regenerate`;
+    console.error(`❌ ${pkgName} ${version} failed to regenerate`);
   }
 }