Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timing data in Sampler #1909

Merged
merged 10 commits into from
Sep 10, 2024
Merged

Timing data in Sampler #1909

merged 10 commits into from
Sep 10, 2024

Conversation

beckykd
Copy link
Collaborator

@beckykd beckykd commented Sep 4, 2024 •
edited
Loading

Should be ready by IEEE

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@beckykd beckykd marked this pull request as ready for review September 5, 2024 18:11
@qiskit-bot
Copy link
Contributor

One or more of the following people are relevant to this code:

ihincks
ihincks reviewed Sep 6, 2024
View reviewed changes
Copy link
Contributor

@ihincks ihincks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Becky!

docs/guides/monitor-job.mdx Outdated Show resolved Hide resolved
docs/guides/monitor-job.mdx Outdated Show resolved Hide resolved
@beckykd @ihincks
Update docs/guides/monitor-job.mdx
e6362d0 
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
@beckykd beckykd requested a review from ihincks September 9, 2024 16:17
ihincks
ihincks reviewed Sep 9, 2024
View reviewed changes
docs/guides/monitor-job.mdx Outdated Show resolved Hide resolved
docs/guides/monitor-job.mdx Outdated Show resolved Hide resolved
docs/guides/monitor-job.mdx Show resolved Hide resolved
docs/guides/monitor-job.mdx Outdated Show resolved Hide resolved
@beckykd @ihincks
Apply suggestions from code review
4ce917e 
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
abbycross
abbycross approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@abbycross abbycross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few tweaks then good to go!

@beckykd @abbycross @Eric-Arellano
Apply suggestions from code review
8066ab0 
Co-authored-by: abbycross <across@us.ibm.com>
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
@beckykd @abbycross
Update docs/guides/primitive-input-output.ipynb
bb207e8 
Co-authored-by: abbycross <across@us.ibm.com>
@beckykd beckykd changed the title (DO NOT MERGE) Timing data in Sampler Timing data in Sampler Sep 10, 2024
@beckykd beckykd added this pull request to the merge queue Sep 10, 2024
Merged via the queue into main with commit 045f452 Sep 10, 2024
4 checks passed
@beckykd beckykd deleted the timing-data-in-Sampler branch September 10, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eric-Arellano Eric-Arellano Eric-Arellano left review comments

@ihincks ihincks ihincks left review comments

@abbycross abbycross abbycross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Docs Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@beckykd @qiskit-bot @ihincks @Eric-Arellano @abbycross