Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1325 Update to the documentation on imporvements to the migration guide #1928

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

quarktetra23
Copy link

I have read the guidelines for contributing to this open source project.

I have provided a comparison table before the introductions of the type of simulators, an attempt to resolve issue #1325 , please let me know if this needs any updates, or more theory on types of simulators needs to be added.

P.S. I have made some minor wording ad spacing changes too.

@CLAassistant
Copy link

CLAassistant commented Sep 11, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

One or more of the following people are relevant to this code:

Copy link
Member

@frankharkins frankharkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this is helpful information. Here's some initial thoughts, our technical writers and subject-matter-experts will have some comments too.

docs/migration-guides/local-simulators.mdx Outdated Show resolved Hide resolved
docs/migration-guides/local-simulators.mdx Outdated Show resolved Hide resolved
Co-authored-by: Frank Harkins <frankharkins@hotmail.co.uk>
Copy link
Collaborator

@beckykd beckykd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good information. Thanks for working on this!

docs/migration-guides/local-simulators.mdx Outdated Show resolved Hide resolved
docs/migration-guides/local-simulators.mdx Outdated Show resolved Hide resolved
docs/migration-guides/local-simulators.mdx Outdated Show resolved Hide resolved
docs/migration-guides/local-simulators.mdx Outdated Show resolved Hide resolved
docs/migration-guides/local-simulators.mdx Outdated Show resolved Hide resolved
docs/migration-guides/local-simulators.mdx Outdated Show resolved Hide resolved
docs/migration-guides/local-simulators.mdx Outdated Show resolved Hide resolved
quarktetra23 and others added 8 commits September 12, 2024 22:09
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
Copy link
Collaborator

@abbycross abbycross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggested changes are mostly changes from camel case to sentence case. Other than that, @beckykd @frankharkins is this ready to merge?

quarktetra23 and others added 3 commits September 18, 2024 12:05
Co-authored-by: abbycross <across@us.ibm.com>
Co-authored-by: abbycross <across@us.ibm.com>
Co-authored-by: abbycross <across@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

6 participants