-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation about the Qiskit Code Assistant #1931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good! Just a few comments.
Question: do you think it would be better to split the content into 2 pages? one for the vscode extension and one for the jupyter lab extension? I felt like the page is quite long while i was reading and if a reader is only interested in one of the methods theres a lot of redundant info
|
||
# Qiskit Code Assistant | ||
|
||
Improve your quantum computing developer experience and learn best practices for Qiskit and IBM Quantum Platform services with Qiskit Code Assistant! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This first paragraph sounds a bit like a marketing advert, could you adjust the tone a bit to be more documentation style?
|
||
### Authentication and setup | ||
|
||
After installing the extension in VSCode or JupyterLab, the extension will try to authenticate you. By default, the package tries to authenticate to IBM Quantum services with the defined Qiskit API token, and uses your token from the `QISKIT_IBM_TOKEN` environment variable or from the file `~/.qiskit/qiskit-ibm.json` (under the section `default-ibm-quantum`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to explain to people how to set their api token env var?
|
||
Jupyterlab also includes a traditional completer than displays suggestion in a context menu rather than inline. This completer can be triggered using `Tab` to run and display the context menu. | ||
|
||
The context menu will include suggestions from the default completer in addition to the Qiskit Code Assistant suggestions. The context menu also sanitizes and trims the suggestions, making it less useful for see the code suggestion before inserting it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typos?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this draft. I'll finish my review tomorrow!
<Admonition type="note"> | ||
This is an experimental feature available only to the IBM Quantum Premium Plan. | ||
The Qiskit Code Assistant is in preview release status, subject to change. | ||
If you have feedback or want to contact the developer team, please use this [Qiskit Slack Workspace channel](https://qiskit.enterprise.slack.com/archives/C07LYA6PL83) or the related public GitHub repositories. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have feedback or want to contact the developer team, please use this [Qiskit Slack Workspace channel](https://qiskit.enterprise.slack.com/archives/C07LYA6PL83) or the related public GitHub repositories. | |
- See the [support page](/support#ibm-quantum-support) to learn how to give feedback or how to contact the development team. |
|
||
1. Launch Visual Studio Code | ||
1. Click on the Extensions tab | ||
1. Search for `qiskit-vscode` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I be able to find this? I don't see it in my VS Code.
I think the tabs component could work quite well here |
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
Splitting in tabs |
…he model and the QHE benchmark
Now the guide uses tabs: one giving an overview about the assistant, other two tabs for the extensions. Addressed some other comments and added some videos about how to use it |
--- | ||
|
||
|
||
# Use the Qiskit Code Assistant in JupyterLab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This intro looks like its for the jupyter lab page not the vscode page?
I’ll stop editing the files unless you ask for it so I don’t interrupt others |
…documentation into add-qiskit-code-assistant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(still reviewing)
## Contribute to the JupyterLab extension | ||
|
||
The code for this official extension is publicly available and open source. Check it out in [github.](https://github.com/Qiskit/qiskit-code-assistant-jupyterlab) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be for VSCode, right?
## Next steps | ||
|
||
<Admonition type="tip" title="Recommendations"> | ||
- Check out examples to use the Qiskit Code Assistant for [circuits](https://docs.quantum.ibm.com/guides/circuit-library), [configuring error suppression](https://docs.quantum.ibm.com/guides/configure-error-suppression), and [transpiling with passmanagers.](transpile-with-pass-managers) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't be love on Monday morning. Should we remove this section for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep
## Next steps | ||
|
||
<Admonition type="tip" title="Recommendations"> | ||
- Check out examples to use the Qiskit Code Assistant for [circuits](https://docs.quantum.ibm.com/guides/circuit-library), [configuring error suppression](https://docs.quantum.ibm.com/guides/configure-error-suppression), and [transpiling with passmanagers.](transpile-with-pass-managers) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
|
||
The code for this extension is publicly available and open source. Check it out in [github.](https://github.com/Qiskit/qiskit-code-assistant-jupyterlab) | ||
|
||
## Next steps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto if this should be removed for now?
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
|
||
<Admonition type="tip" title="Recommendations"> | ||
- Install and use the official [JupyterLab](/guides/qiskit-code-assistant-jupyterlab) or [VSCode](/guides/qiskit-code-assistant-vscode) extensions. | ||
- Follow examples to use the Qiskit Code Assistant for [circuits](https://docs.quantum.ibm.com/guides/circuit-library), [configuring error suppression](https://docs.quantum.ibm.com/guides/configure-error-suppression), and [transpiling with passmanagers.](transpile-with-pass-managers) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be removed for now
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Thank you!! 🙏 |
1st draft for documentation about the Qiskit Code Assistant. Should fix #1930 Considerations: - Rough draft, feel free to edit or give any feedback - I'm not sure if we should split the documentation in 2 parts: one for JupyterLab extension and another one for the VSCode extension - I'm not sure the where the Qiskit Code Assistant should be placed in the TOC - I added content that depends on #1918 --------- Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com> Co-authored-by: Rebecca Dimock <beckyd@us.ibm.com> Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
1st draft for documentation about the Qiskit Code Assistant. Should fix #1930
Considerations: