Make link checker more precise #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
force-pushed
the
EA/more-api-links
branch
from
96e7e70
to
8fd0df4
Compare
Eric-Arellano
changed the title
frankharkins
approved these changes
Sep 16, 2024
frankharkins
pushed a commit
that referenced
this pull request
Sep 18, 2024
Closes #495. We are checking every Runtime and qiskit-ibm-transpiler version, plus Qiskit 0.46+. This PR makes it more explicit and precise which links we have to ignore to get that green. That reduces the risk of false positives. This PR also now has the external link checker check every single Qiskit version, whereas before it skipped historical links. It's important we don't have 404s, even for old docs. Note that the external link checker doesn't check GitHub source code links, which makes this change much less expensive. The remaining issues are tracked by #1938.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #495.
We are checking every Runtime and qiskit-ibm-transpiler version, plus Qiskit 0.46+. This PR makes it more explicit and precise which links we have to ignore to get that green. That reduces the risk of false positives.
This PR also now has the external link checker check every single Qiskit version, whereas before it skipped historical links. It's important we don't have 404s, even for old docs. Note that the external link checker doesn't check GitHub source code links, which makes this change much less expensive.
The remaining issues are tracked by #1938.