-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address image issues and associated text in Transpiler stages page #674
Conversation
@kaelynj do you still have this image? -- and if so, would it be complicated to switch the background to light mode? We have functionality to automatically change an image based on the user's light/dark mode preferences. |
If and only if we provide the dark mode variant of the image. |
The image we have now would serve as the dark mode version -- unless it can't for some reason @Eric-Arellano ? |
I only have the dark mode version unfortunately. I got it from someone else to make slides from and can ask if they have a light mode version of it. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Co-Authored-By: Frank Harkins <frankharkins@hotmail.co.uk>
Thanks for the tip @frankharkins ! I tried out bringing in the image you created and it works to switch from light to dark. |
Co-authored-by: abbycross <across@us.ibm.com>
…ocumentation into ajc/update-transpiler-stages-pg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me!
Ah, @Eric-Arellano, looks like some of the checks are failing b/c the tox environment does not contain the |
It's installed at the OS-level, not Python package manager. So it's more complex than normal but not too bad. You would add documentation/.github/workflows/notebook-test.yml Lines 46 to 50 in 75aaa31
Rename the job title from "Install LaTeX dependencies" to "Install Linux dependencies" |
PR #674 had an issue with automated checks and needs the `graphviz` package to run `plot_circuit_layout()` function. --------- Co-authored-by: ABBY CROSS <across@us.ibm.com> Co-authored-by: Frank Harkins <frankharkins@hotmail.co.uk>
…iskit#674) Closes Qiskit#657 --------- Co-authored-by: Frank Harkins <frankharkins@hotmail.co.uk> Co-authored-by: Kaelyn Ferris <43348706+kaelynj@users.noreply.github.com> Co-authored-by: kaelynj <kaelyn.ferris@gmail.com>
PR Qiskit#674 had an issue with automated checks and needs the `graphviz` package to run `plot_circuit_layout()` function. --------- Co-authored-by: ABBY CROSS <across@us.ibm.com> Co-authored-by: Frank Harkins <frankharkins@hotmail.co.uk>
Closes #657