Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address image issues and associated text in Transpiler stages page #674

Merged
merged 21 commits into from
Jan 31, 2024

Conversation

abbycross
Copy link
Collaborator

Closes #657

@abbycross
Copy link
Collaborator Author

@kaelynj do you still have this image? -- and if so, would it be complicated to switch the background to light mode? We have functionality to automatically change an image based on the user's light/dark mode preferences.

image

@Eric-Arellano
Copy link
Collaborator

We have functionality to automatically change an image based on the user's light/dark mode preferences.

If and only if we provide the dark mode variant of the image.

@abbycross
Copy link
Collaborator Author

We have functionality to automatically change an image based on the user's light/dark mode preferences.

If and only if we provide the dark mode variant of the image.

The image we have now would serve as the dark mode version -- unless it can't for some reason @Eric-Arellano ?

@kaelynj
Copy link
Collaborator

kaelynj commented Jan 22, 2024

I only have the dark mode version unfortunately. I got it from someone else to make slides from and can ask if they have a light mode version of it.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@frankharkins
Copy link
Member

If we can't get the light-mode version, you can make a rough one by inverting the image, then inverting the hue to preserve the colours.

298724279-fe821ccb-0f53-47da-83d6-478a1974b162

Co-Authored-By: Frank Harkins <frankharkins@hotmail.co.uk>
@abbycross
Copy link
Collaborator Author

If we can't get the light-mode version, you can make a rough one by inverting the image, then inverting the hue to preserve the colours.

Thanks for the tip @frankharkins ! I tried out bringing in the image you created and it works to switch from light to dark.

Co-authored-by: abbycross <across@us.ibm.com>
Copy link
Collaborator

@kaelynj kaelynj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me!

@kaelynj
Copy link
Collaborator

kaelynj commented Jan 30, 2024

Ah, @Eric-Arellano, looks like some of the checks are failing b/c the tox environment does not contain the graphviz library. Is it straightforward to add in/are there any concerns about the prod environment?

@Eric-Arellano
Copy link
Collaborator

Is it straightforward to add in/are there any concerns about the prod environment?

It's installed at the OS-level, not Python package manager. So it's more complex than normal but not too bad. You would add graphviz to this line:

- name: Install LaTeX dependencies
if: steps.latex-changed-files.outputs.any_changed == 'true'
run: |
sudo apt-get update
sudo apt-get install texlive-pictures texlive-latex-extra poppler-utils

Rename the job title from "Install LaTeX dependencies" to "Install Linux dependencies"

@abbycross abbycross added this pull request to the merge queue Jan 31, 2024
Merged via the queue into main with commit 2f14936 Jan 31, 2024
4 of 5 checks passed
@abbycross abbycross deleted the ajc/update-transpiler-stages-pg branch January 31, 2024 14:56
@kaelynj kaelynj restored the ajc/update-transpiler-stages-pg branch January 31, 2024 16:58
github-merge-queue bot pushed a commit that referenced this pull request Jan 31, 2024
PR #674 had an issue with automated checks and needs the `graphviz`
package to run `plot_circuit_layout()` function.

---------

Co-authored-by: ABBY CROSS <across@us.ibm.com>
Co-authored-by: Frank Harkins <frankharkins@hotmail.co.uk>
frankharkins added a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
…iskit#674)

Closes Qiskit#657

---------

Co-authored-by: Frank Harkins <frankharkins@hotmail.co.uk>
Co-authored-by: Kaelyn Ferris <43348706+kaelynj@users.noreply.github.com>
Co-authored-by: kaelynj <kaelyn.ferris@gmail.com>
frankharkins added a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
PR Qiskit#674 had an issue with automated checks and needs the `graphviz`
package to run `plot_circuit_layout()` function.

---------

Co-authored-by: ABBY CROSS <across@us.ibm.com>
Co-authored-by: Frank Harkins <frankharkins@hotmail.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Image issues in transpiler stages topic
4 participants