Cap flask version #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our use of `before_first_request` decorator to lazily initialize the repositories and configuration of the webapp was deprecated and removed in the 2.3.x release series. We'll have to reorganize the api module to conform to more modern flask conventions to do this initial setup. In the meantime this commit just caps our flask requirement to avoid 2.3.x. This issue was never caught in the deployed service because we were deploying the bot using Python 3.7 which effectively was capping us flask<2.3. Trying to update the deployment to use Python 3.11 instead the service never starts because 2.3 is being installed.
jakelishman
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our use of
before_first_requestdecorator to lazily initialize the repositories and configuration of the webapp was deprecated and removed in the 2.3.x release series. We'll have to reorganize the api module to conform to more modern flask conventions to do this initial setup. In the meantime this commit just caps our flask requirement to avoid 2.3.x.This issue was never caught in the deployed service because we were deploying the bot using Python 3.7 which effectively was capping us flask<2.3. Trying to update the deployment to use Python 3.11 instead the service never starts because 2.3 is being installed.