Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in the notification message #45

Closed
wants to merge 1 commit into from
Closed

Fix typo in the notification message #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion qiskit_bot/notifications.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def _process_notification():
buf.write(prelude)
if notify_list:
buf.write(
"\nOne or more of the the following people are "
"\nOne or more of the following people are "
"requested to review this:\n"
)
for user in sorted(notify_list):
Expand Down
10 changes: 5 additions & 5 deletions tests/test_notifications.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def test_basic_notification(self, sub_mock):
inner_func = sub_mock.call_args_list[0][1]['target']
inner_func()
expected_body = notifications.DEFAULT_PRELUDE + (
"\nOne or more of the the following people are requested to "
"\nOne or more of the following people are requested to "
"review this:\n- @user1\n- @user2\n"
)
gh_mock.get_pull.assert_called_once_with(1234)
Expand Down Expand Up @@ -94,7 +94,7 @@ def test_no_prelude_for_team_mbembers(self, sub_mock):
inner_func = sub_mock.call_args_list[0][1]['target']
inner_func()
expected_body = (
"\nOne or more of the the following people are requested to "
"\nOne or more of the following people are requested to "
"review this:\n- '@user1'\n- '@user2'\n"
)
gh_mock.get_pull.assert_called_once_with(1234)
Expand Down Expand Up @@ -129,7 +129,7 @@ def test_multiple_overlapping_file_notifications(self, sub_mock):
inner_func = sub_mock.call_args_list[0][1]['target']
inner_func()
expected_body = notifications.DEFAULT_PRELUDE + (
"\nOne or more of the the following people are requested to "
"\nOne or more of the following people are requested to "
"review this:\n- @user1\n- @user2\n- @user3\n"
)

Expand Down Expand Up @@ -196,7 +196,7 @@ def test_one_hit_multiple_notification_rules(self, sub_mock):
inner_func = sub_mock.call_args_list[0][1]['target']
inner_func()
expected_body = notifications.DEFAULT_PRELUDE + (
"\nOne or more of the the following people are requested to "
"\nOne or more of the following people are requested to "
"review this:\n- @user1\n- @user2\n"
)
gh_mock.get_pull.assert_called_once_with(1234)
Expand Down Expand Up @@ -330,7 +330,7 @@ def test_match_custom_prelude(self, sub_mock):
inner_func()
expected_body = """This is my prelude

One or more of the the following people are requested to review this:
One or more of the following people are requested to review this:
- @user1
- @user2
"""
Expand Down