Remove 0.24.0 deprecations #1907
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt474
added
the
Changelog: Removal
ptristan3
reviewed
Sep 10, 2024
| "{'environment': {'log_level': 'INFO'}} instead of {'log_level': 'INFO'}.", | ||
| 4, | ||
| ) | ||
| self._options = self._options_class(**merge_options_v2(default_options, options)) |
There was a problem hiding this comment.
We shouldn't keep the try/except?
ptristan3
reviewed
Sep 11, 2024
Comment on lines
+154
to
+155
| merged = merge_options_v2(self, kwargs) | ||
| _set_attr(merged) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes/updates everything that was deprecated in the
0.24.0release.BackendV1related things will be taken care of in a separate PRChanges:
Sessionproperty has been replaced withmodeJob.program_id()has been replaced withJob.primitive_id()Service.run()andSession.run()have been replaced with a private method,_run()Service.backend(), "name" is now a required parameterService.get_backend()removed, replaced withbackend()Details and comments
Fixes #1911