Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 1.0.0b1 release #11353

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Prepare 1.0.0b1 release #11353

merged 2 commits into from
Dec 1, 2023

Conversation

mtreinish
Copy link
Member

Summary

This commit changes the version strings from 1.0.0 to 1.0.0pre1 in preparation for tagging the 1.0.0pre1 release. After the tag we should switch the version number back to continue developing the 1.0.0 release series as we approach the actual release.

Details and comments

This commit changes the version strings from 1.0.0 to 1.0.0pre1 in
preparation for tagging the 1.0.0pre1 release. After the tag we should
switch the version number back to continue developing the 1.0.0 release
series as we approach the actual release.
@mtreinish mtreinish added the Changelog: None Do not include in changelog label Nov 30, 2023
@mtreinish mtreinish added this to the 1.0.0pre1 milestone Nov 30, 2023
@mtreinish mtreinish requested a review from a team as a code owner November 30, 2023 18:01
@mtreinish
Copy link
Member Author

We probably want to wait for Qiskit/qiskit-bot#43 to merge and be deployed before we move ahead with this.

@coveralls
Copy link

coveralls commented Nov 30, 2023

Pull Request Test Coverage Report for Build 7051797779

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 16 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 87.431%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 93.76%
crates/qasm2/src/lex.rs 3 91.41%
crates/qasm2/src/parse.rs 12 97.13%
Totals Coverage Status
Change from base Build 7049384648: -0.02%
Covered Lines: 59818
Relevant Lines: 68417

💛 - Coveralls

@mtreinish
Copy link
Member Author

We hit a snag using pre1 one as PEP440 calls for pre1 to be normalized to rc1 https://packaging.python.org/en/latest/specifications/version-specifiers/#normalization which would conflict with the eventual rc1 release. So I'll respin this PR to use 1.0.0b1 instead.

@mtreinish mtreinish added the on hold Can not fix yet label Nov 30, 2023
@jakelishman jakelishman changed the title Prepare 1.0.0pre1 release Prepare 1.0.0b1 release Nov 30, 2023
@jakelishman
Copy link
Member

Just thinking: maybe we want to make this version-number bump on a separate semi-stable branch, just on the off-chance we need to make emergency post-release patches to the beta? It'd be a nuisance if we have to roll main forwards and backwards.

docs/conf.py Outdated
Comment on lines 29 to 33
# The short X.Y version
version = "1.0"
# The full version, including alpha/beta/rc tags
release = "1.0.0"
release = "1.0.0pre1"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I actually should make the docs read this out of the package as part of the "single source of truth" for the versioning. I didn't think about that at the time.

@mtreinish
Copy link
Member Author

Just thinking: maybe we want to make this version-number bump on a separate semi-stable branch, just on the off-chance we need to make emergency post-release patches to the beta? It'd be a nuisance if we have to roll main forwards and backwards.

I was really hoping for a one and done here. The preview release is just supposed to be a snapshot of the current state of the repo without any commitments. Aside from needing a post release to fix a packaging bug (the changes in packaging are the biggest concern for me with this release) which we'd hopefully catch immediately I can't think of any reason to do a 1.0.0b2

@mtreinish
Copy link
Member Author

That being said if we do need to do a 1.0.0b2, it'll be simple enough to create a branch from the 1.0.0b1 tag. Or were you more just advocating that we create a beta branch from main and retarget this PR to that branch?

@jakelishman
Copy link
Member

Nah, you're right - if it becomes necessary (and I hope it doesn't), let's just branch retrospectively from the tag.

@mtreinish mtreinish removed the on hold Can not fix yet label Dec 1, 2023
@jakelishman jakelishman added this pull request to the merge queue Dec 1, 2023
Merged via the queue into Qiskit:main with commit fa31085 Dec 1, 2023
14 checks passed
mtreinish added a commit that referenced this pull request Dec 1, 2023
github-merge-queue bot pushed a commit that referenced this pull request Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants