Fix Clippy warnings on stable/0.15 branch #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanIsCoding
added
stable-backport-potential
Pull Request Test Coverage Report for Build 10152169061Details
💛 - Coveralls |
IvanIsCoding
removed
the
stable-backport-potential
--- updated-dependencies: - dependency-name: serde_json dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Ivan Carvalho <ivancarv@student.ubc.ca> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
IvanIsCoding
force-pushed
the
fix-clippy-180
branch
from
d48ac99
to
b2f6974
Compare
IvanIsCoding
changed the title
mtreinish
approved these changes
Jul 30, 2024
|
@mtreinish I think this PR got stuck waiting for steps that don’t exist. Is there a way to disable those? |
|
Ah yeah, I see that now. I'll update the branch protection rules |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to unblock CI for the future backports of #1246 and #1247. The lints were super simple this time, we only changed docstrings not code.