-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move more connected components functions to retworkx-core #638
base: main
Are you sure you want to change the base?
Conversation
Hello, I get this error I am also not sure how to import |
I was planning on doing a review of this in the next couple of days. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a number of changes here, but hopefully they are straightforward. There will need to be a couple of tests added and probably a features
release note, but those can be done later after you get everything working.
Feel free to ask any questions along the way.
Oh one more important thing I forgot. You need to transition to using the
|
Apologies for the late implementation of the feedback. I have started making the corresponding naming changes and will commit any relevant changes. Thank you for the help! |
f937eb5
to
efe8287
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far with one change. You should be able to do cargo build
without errors on your local branch once you've made the change to rustworkx
. You also might want to run cargo fmt
in case there are some formatting changes. Once you get a clean build, we can talk about testing.
@IvanIsCoding or @mtreinish Can you turn on the workflow testing here? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more changes should get a clean build.
Hi, @kris524. Just checking to see if you are still working on this. Thanks. |
Hi @enavarro51 apologies for being slow, I was just busy. Is it ok if I have a look at it this weekend? I think I am close to finishing it. |
@kris524. That's fine. Once you get a good build, you can add a test for each of the 2 new functions at the end of |
Tomorrow I will write a test for |
@enavarro51 Let me know if you are happy with the tests. |
No description provided.