Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of cycle_basis_edges #885

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Commits on Aug 11, 2023

  1. Initial implementation of cycle_basis_edges

    - Inspired from the existing procedure `cycle_basis`.
    - Modified to return a tuple of `NodeId` in format `(source, target)`.
    - Added API calls so that method works in Python.
    raynelfss committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    62f26f9 View commit details
    Browse the repository at this point in the history
  2. Hotfix: DocTest now passes

    raynelfss committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    35eea7e View commit details
    Browse the repository at this point in the history
  3. Correction: Function returns EdgeIndex

    - Cycle_basis_edges now returns a list of edgeIDs.
    raynelfss committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    a8c1b67 View commit details
    Browse the repository at this point in the history
  4. Docs: Added release note

    raynelfss committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    c22c0b5 View commit details
    Browse the repository at this point in the history
  5. CI: Added python tests to test_cycle_basis.py

    - Added `TestCycleBasisEdges` class for unit testing.
    - Added similar tests to those present on `TestCycleBasis`.
        - Tests are similar due to the same methodology.
        - Graphs used for testing are different.
    raynelfss committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    c6dea4e View commit details
    Browse the repository at this point in the history
  6. Correction: get_edge_between checks target only

    - Modified get_edge_between to only check target when equiv == false.
    raynelfss committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    23f2759 View commit details
    Browse the repository at this point in the history
  7. Feature: merge basis and basis_edges into one

    - Cycle basis edges is now within the codebase of cycle basis.
    - The `EdgesOrNodes` enum handles the different return data types.
    raynelfss committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    dadb482 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    50d8685 View commit details
    Browse the repository at this point in the history
  9. Docs: made changes to releasenotes and api.rst

    - Release notes now include an example with a jupyter notebook.
    raynelfss committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    7c45634 View commit details
    Browse the repository at this point in the history
  10. Fix: Make cycle_basis and EdgeOrNode private

    - A previous commit inadvertedly made cycle_basis prublic.
        - To address this, two new public-facing functions were added:
            - `cycle_basis` for NodeId returns.
            - `cycle_basis_edges` for EdgeId returns.
    - When customizing cycle_basis a new enum EdgesOrNodes was made.
        - Enum should not be have been shared by definition.
            - Correction makes it private.
        - Removed redundant import from unwrap methods.
    - Tests have been adjusted accordingly.
    raynelfss committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    c0f9f94 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    df5b3b5 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    26146af View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    f3f271a View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    70541c8 View commit details
    Browse the repository at this point in the history
  15. Correction: get_edge_between returns EdgeId.

    - The method returns the first edge found between nodes.
    - The docstring for this method was corrected.
    raynelfss committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    dc7eb26 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    38bdeac View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    075b2f0 View commit details
    Browse the repository at this point in the history
  18. Fix: Pop unwrap warning by clippy.

    - Use while let statement to continuously pop the queue.
    raynelfss committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    151a314 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. Configuration menu
    Copy the full SHA
    7f52970 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Configuration menu
    Copy the full SHA
    10c16bf View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Configuration menu
    Copy the full SHA
    62169b4 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Configuration menu
    Copy the full SHA
    6d11293 View commit details
    Browse the repository at this point in the history