Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[commod_price] Update editorial suggestions #443

Merged
merged 14 commits into from
Jul 8, 2024
Merged

[commod_price] Update editorial suggestions #443

merged 14 commits into from
Jul 8, 2024

Conversation

SylviaZhaooo
Copy link
Collaborator

Resolve most comments in #436.

@SylviaZhaooo SylviaZhaooo requested a review from mmcky May 9, 2024 05:38
@netlify Netlify
Copy link

netlify bot commented May 9, 2024 •
edited
Loading

✅ Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 053c529
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/668b650fb9b7570008701acc
😎 Deploy Preview https://deploy-preview-443--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024 •
edited
Loading

🚀 Deployed on https://668b66ef20d06465c1409b9d--taupe-gaufre-c4e660.netlify.app

@github-actions github-actions bot temporarily deployed to pull request May 9, 2024 05:46 Inactive
mmcky
mmcky reviewed May 9, 2024
View reviewed changes
lectures/commod_price.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request May 10, 2024 07:16 Inactive
mmcky
mmcky reviewed May 21, 2024
View reviewed changes
lectures/commod_price.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request May 22, 2024 05:19 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 22, 2024 06:48 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 18, 2024 05:12 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 18, 2024 05:13 Inactive
mmcky
mmcky requested changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @SylviaZhaooo just added some more comments.

lectures/commod_price.md Outdated Show resolved Hide resolved
lectures/commod_price.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request June 30, 2024 07:32 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 30, 2024 07:33 Inactive
@mmcky
Copy link
Contributor

mmcky commented Jun 30, 2024

@SylviaZhaooo if you agree with my "suggested" commits in the comments above. Please go ahead and click on "Commit Suggestion". Otherwise it would be great if you could add a comment when you're ready to each so I know they have been addressed. Thank you.

@SylviaZhaooo @mmcky
Update lectures/commod_price.md
2b2a55a 
Co-authored-by: Matt McKay <mmcky@users.noreply.github.com>
@github-actions github-actions bot temporarily deployed to pull request July 1, 2024 00:01 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 1, 2024 00:03 Inactive
@SylviaZhaooo
Copy link
Collaborator Author

@SylviaZhaooo if you agree with my "suggested" commits in the comments above. Please go ahead and click on "Commit Suggestion". Otherwise it would be great if you could add a comment when you're ready to each so I know they have been addressed. Thank you.

Sorry for the late reply. I clicked on "Commit Suggestion" and "Resolve Conversation".

mmcky
mmcky reviewed Jul 1, 2024
View reviewed changes
lectures/monte_carlo.md Outdated Show resolved Hide resolved
@SylviaZhaooo @mmcky
Update lectures/monte_carlo.md
c51ec04 
Co-authored-by: Matt McKay <mmcky@users.noreply.github.com>
@github-actions github-actions bot temporarily deployed to pull request July 1, 2024 00:27 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 1, 2024 00:28 Inactive
mmcky
mmcky approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @SylviaZhaooo

@mmcky mmcky added the ready label Jul 1, 2024
@jstac jstac mentioned this pull request Jul 1, 2024
Closed
8 tasks
@github-actions github-actions bot temporarily deployed to pull request July 1, 2024 00:59 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 1, 2024 01:01 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 5, 2024 04:49 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 5, 2024 04:51 Inactive
@SylviaZhaooo
Copy link
Collaborator Author

SylviaZhaooo commented Jul 8, 2024 •
edited
Loading

Resolve the comments by @Jiarui-ZH in #436.

@github-actions github-actions bot temporarily deployed to pull request July 8, 2024 02:29 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 8, 2024 02:31 Inactive
@mmcky mmcky self-requested a review July 8, 2024 03:18
@SylviaZhaooo SylviaZhaooo added in-work and removed ready labels Jul 8, 2024
mmcky
mmcky reviewed Jul 8, 2024
View reviewed changes
lectures/commod_price.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request July 8, 2024 04:09 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 8, 2024 04:11 Inactive
@mmcky
Copy link
Contributor

mmcky commented Jul 8, 2024

thanks for your edits @jstac. Please let me know if this is ready to merge.

@jstac jstac merged commit 45215d6 into main Jul 8, 2024
7 checks passed
@jstac jstac deleted the update_commod_price branch July 8, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmcky mmcky mmcky approved these changes

Assignees
No one assigned
Labels
in-work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SylviaZhaooo @mmcky @jstac @HumphreyYang