Skip to content
This repository has been archived by the owner on Sep 21, 2021. It is now read-only.

Update getting_started.ipynb #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kirillseva
Copy link

Did not work 🙅

julia> github_project("QuantEcon/quantecon-notebooks-julia", version = "0.8.0", instantiate = true, precompile = true)
ERROR: MethodError: no method matching github_project(::String; version="0.8.0", instantiate=true, precompile=true)
Closest candidates are:
  github_project(::Any; path, version, force) at /Users/kirillseva/.julia/packages/InstantiateFromURL/stReR/src/github_project.jl:31 got unsupported keyword arguments "instantiate", "precompile"
Stacktrace:
 [1] kwerr(::NamedTuple{(:version, :instantiate, :precompile),Tuple{String,Bool,Bool}}, ::Function, ::String) at ./error.jl:157
 [2] top-level scope at none:0

Worked ✅

julia>  github_project("QuantEcon/quantecon-notebooks-julia", version = "0.8.0", force = true)

Did not work 🙅 

```sh
julia> github_project("QuantEcon/quantecon-notebooks-julia", version = "0.8.0", instantiate = true, precompile = true)
ERROR: MethodError: no method matching github_project(::String; version="0.8.0", instantiate=true, precompile=true)
Closest candidates are:
  github_project(::Any; path, version, force) at /Users/kirillseva/.julia/packages/InstantiateFromURL/stReR/src/github_project.jl:31 got unsupported keyword arguments "instantiate", "precompile"
Stacktrace:
 [1] kwerr(::NamedTuple{(:version, :instantiate, :precompile),Tuple{String,Bool,Bool}}, ::Function, ::String) at ./error.jl:157
 [2] top-level scope at none:0
```

Worked ✅ 
```julia
julia>  github_project("QuantEcon/quantecon-notebooks-julia", version = "0.8.0", force = true)
```
@jlperla
Copy link
Member

jlperla commented Jun 7, 2020 via email

@@ -374,7 +374,7 @@
"source": [
"```julia\n",
"using InstantiateFromURL\n",
"github_project(\"QuantEcon/quantecon-notebooks-julia\", version = \"0.8.0\", instantiate = true, precompile = true)\n",
"github_project(\"QuantEcon/quantecon-notebooks-julia\", version = \"0.8.0\", force = true)\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a change in instantiatefromurl to add a new feature for precompilation control in https://github.com/QuantEcon/InstantiateFromURL.jl/releases/tag/v0.5.0

So my guess is that you have an older version of that package and that a ] up InstantiateFromURL (done OUTISIDE of the activated quantecon notebooks environment) could do the trick. Then you could delete the notebooks, follow the setup instructions, and I bet it works great.

The issue with force is that it forces an overwrite and download - which is generally not what you want when you have a cloned notebook repository.

Feel free to post on discourse.quantecon.org to discuss.

Also note that our source to generate these notebooks is in https://github.com/QuantEcon/lecture-source-jl so if you have found a bug we fix it there.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlperla fresh julia install and getting this error. up InstantiateFromURL didn't help either. I understand why you split force into two separate parameters, but it sounds like package publishing didn't work out?

Feel free to close this pull request and address it in the source repo. I was actually wondering how you maintain a collection of ipython notebooks - now I know :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. @arnav sorry to bug you, but any ideas with your InstantiateFromURL updates? Did you have issues when you did the local testing with the v0. 8?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants