Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Blockly language for default locale #91

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

DenisaCG
Copy link
Member

@DenisaCG DenisaCG commented Aug 19, 2024

In the Settings Editor in JupyterLab the locale settings (language) get initialized with default instead of En, representing English. This PR updates the logic such that it deals with the default case by loading the English message pack for Blockly.

@DenisaCG DenisaCG self-assigned this Aug 19, 2024
@DenisaCG DenisaCG added the bug Something isn't working label Aug 19, 2024
Copy link
Contributor

Binder 👈 Launch a Binder on branch QuantStack/jupyterlab-blockly/fixBlocklyLanguage

@DenisaCG DenisaCG merged commit 567d75e into main Aug 19, 2024
9 checks passed
@DenisaCG DenisaCG deleted the fixBlocklyLanguage branch August 19, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant