Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add example video #19

Closed
wants to merge 2 commits into from
Closed

docs: add example video #19

wants to merge 2 commits into from

Conversation

pavelzw
Copy link
Member

@pavelzw pavelzw commented Jun 6, 2024

Motivation

Changes

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 6, 2024
@pavelzw pavelzw marked this pull request as ready for review June 6, 2024 11:31
@pavelzw pavelzw requested review from delsner and 0xbe7a as code owners June 6, 2024 11:31
delsner
delsner approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@delsner delsner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, one nitpick: would you mind capturing only the iterm window in the video 😇? should be Shift+CMD+5 -> "Record selected portion" on macOS

@pavelzw
Copy link
Member Author

pavelzw commented Jun 7, 2024

superseded by #23

@pavelzw pavelzw closed this Jun 7, 2024
@pavelzw pavelzw deleted the example-video branch June 7, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delsner delsner delsner approved these changes

@0xbe7a 0xbe7a Awaiting requested review from 0xbe7a

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelzw @delsner