chore: use cross for linux-arm builds #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xbe7a
changed the title
|
Builds are now succeeding. I have used cross for all linux builds @pavelzw |
pavelzw
approved these changes
Jul 16, 2024
| @@ -33,18 +33,25 @@ jobs: | |||
| include: | |||
| - target: x86_64-unknown-linux-musl | |||
| os: ubuntu-latest | |||
| cross: true | |||
There was a problem hiding this comment.
is there a benefit of using cross for x86?
There was a problem hiding this comment.
Having a working cross-configuration, which includes a complete and reproducible non-rustc toolchain is preferable from a developer's standpoint as it makes debugging and testing easier. Cross can still make use of caching, so I don't think there are any major downsides to using it. Additionally, our CI ensures that the cross-configurations remain functional.
Co-authored-by: Pavel Zwerschke <pavel.zwerschke@quantco.com>
Co-authored-by: Pavel Zwerschke <pavel.zwerschke@quantco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ubuntu-arm runners are not available in public repos
Changes
Use cargo-cross to cross-compile for linux-aarch