Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix resource leak for tmp dir during unpack #42

Merged
merged 1 commit into from
Aug 9, 2024
Merged

fix: Fix resource leak for tmp dir during unpack #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/unpack.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,13 @@ pub struct UnpackOptions {

/// Unpack a pixi environment.
pub async fn unpack(options: UnpackOptions) -> Result<()> {
let unpack_dir = tempfile::tempdir()
.map_err(|e| anyhow!("Could not create temporary directory: {}", e))?
.into_path();

let tmp_dir =
tempfile::tempdir().map_err(|e| anyhow!("Could not create temporary directory: {}", e))?;
let unpack_dir = tmp_dir.path();
let channel_directory = unpack_dir.join(CHANNEL_DIRECTORY_NAME);

tracing::info!("Unarchiving pack to {}", unpack_dir.display());
unarchive(&options.pack_file, &unpack_dir)
unarchive(&options.pack_file, unpack_dir)
.await
.map_err(|e| anyhow!("Could not unarchive: {}", e))?;

Expand Down