feat: Init test suite #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delsner
commented
Jun 3, 2024
delsner
commented
Jun 3, 2024
| } | ||
|
|
||
| #[fixture] | ||
| fn metadata_file( |
There was a problem hiding this comment.
These are just some sample test cases s.t. we can get started with unit testing.
delsner
commented
Jun 3, 2024
.github/workflows/ci.yml
Outdated
There was a problem hiding this comment.
TODO add coverage + codecov upload here
delsner
commented
Jun 3, 2024
| @@ -6,6 +6,8 @@ edition = "2021" | |||
|
|
|||
| [features] | |||
| default = ["tokio/rt-multi-thread"] | |||
| # Activate this feature to activate online-testing in the integration test suite. | |||
| online-test = [] | |||
There was a problem hiding this comment.
Is conditional compilation the way to go for implementing something like pytest markers? (I want to mark those tests that require an internet connection to fetch packages.)
delsner
commented
Jun 3, 2024
pavelzw
reviewed
Jun 3, 2024
Co-authored-by: Pavel Zwerschke <pavel.zwerschke@quantco.com>
Co-authored-by: Pavel Zwerschke <pavel.zwerschke@quantco.com>
Co-authored-by: Pavel Zwerschke <pavel.zwerschke@quantco.com>
pavelzw
approved these changes
Jun 4, 2024
|
Let's fix #8 in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
No tests.
Changes
examples/