Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Write pixi-pack-version to metadata file #62

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Conversation

pavelzw
Copy link
Member

@pavelzw pavelzw commented Oct 25, 2024

Motivation

Would be nice to have some information what was being used to generate the pack file. Is also nice for reproducibility

Changes

Write pixi-pack-version to pixi-pack.json.
If the version differs during unpack, we will print a WARN (only gets shown when pixi-pack unpack -v).

Make version Option to support older versions of pixi-pack.

@pavelzw pavelzw requested a review from delsner as a code owner October 25, 2024 10:01
@github-actions github-actions bot added the enhancement New feature or request label Oct 25, 2024
Copy link
Member

@delsner delsner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pavelzw pavelzw enabled auto-merge (squash) October 25, 2024 10:11
@pavelzw pavelzw merged commit 0dede4b into main Oct 25, 2024
16 checks passed
@pavelzw pavelzw deleted the pixi-pack-version branch October 25, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants