adding all missing types of two qubit SWAP gates and sSQRTZZ/sInvSQRTZZ gate #336

Fe-r-oz · 2024-08-07T13:07:54Z

This PR aims to add new types of SWAP gates.

Reference: https://github.com/quantumlib/Stim/blob/main/doc/gates.md

Exact notation as stim uses has been used. There were many 2 qubit gates, so I decided to go small steps at a time.

Thank you for reviweing the PR.

julia> sCXSWAP(1,2)
sCXSWAP on qubit1 (1,2)
X₁ ⟼ + XX
X₂ ⟼ + X_
Z₁ ⟼ + _Z
Z₂ ⟼ + ZZ

julia> sCZSWAP(1,2)
sCZSWAP on qubit1 (1,2)
X₁ ⟼ + ZX
X₂ ⟼ + XZ
Z₁ ⟼ + _Z
Z₂ ⟼ + Z_

julia> sSWAPCX(1,2)
sSWAPCX on qubit1 (1,2)
X₁ ⟼ + _X
X₂ ⟼ + XX
Z₁ ⟼ + ZZ
Z₂ ⟼ + Z_

julia> sSWAPCXDAG(1,2)
sSWAPCXDAG on qubit1 (1,2)
X₁ ⟼ + XX
X₂ ⟼ + X_
Z₁ ⟼ + _Z
Z₂ ⟼ + ZZ

f you want to submit an unfinished piece of work in order to get comments and discuss, please mark the pull request as a draft and ping the repository maintainer.

Please address only one topic or issue per pull request! Many small PRs are much easier to review and merge than one large PR.

Before merging, all changes and new functionality should be marked in the CHANGELOG file, but feel free to just leave your CHANGELOG notes in the PR description, to avoid merge conflicts with other requests modifying that file. The maintainer will add these CHANGELOG notes for you if you do so.

Before considering your pull request ready for review and merging make sure that all of the following are completed (please keep the clecklist as part of your PR):

The code is properly formatted and commented.
All new functionality is tested.
All of the automated tests on github pass.

If possible, keep your git history not too wild (rebase and squash commits, keep commits small and semantically separated) so that review is easier.

codecov · 2024-08-07T13:29:59Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.45%. Comparing base (e51a142) to head (b2d1264).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
+ Coverage   82.44%   82.45%   +0.01%     
==========================================
  Files          62       62              
  Lines        4186     4190       +4     
==========================================
+ Hits         3451     3455       +4     
  Misses        735      735

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Krastanov

This looks great! Same comments as in #333

Fe-r-oz · 2024-08-15T11:46:45Z

Added ISWAP and it's inverse as well so we now have all types of two qubit SWAP gates w.r.t to stim.
Also, added SQRTZZ and it's inverse for now! Followed your task todo list for these latest additions as well!

EDIT: (skipped to keep track of referencing to related open issues (if any))

This PR introduces the following gates w.r.t to #45:

✓ sSWAPCX
✓ sInvSWAPCX
✓ sCZSWAP
✓ sCXSWAP
✓ sISWAP
✓ sInvISWAP
✓ sSQRTZZ
✓ sInvSQRTZZ

…SQRTZZ and sInvSQRTZZ gates

Krastanov

This would be a pretty nice addition, thank you! I have a few questions on where some of the definitions are coming from.

Krastanov · 2024-09-14T02:43:43Z

test/test_symcliff.jl

@@ -88,6 +88,19 @@
 @test CliffordOperator(inv(sXCZ(n₁, n₂)), n₁) == inv(CliffordOperator(sCNOT(n₂, n₁), n₁))
 @test CliffordOperator(inv(sZCrY(n₁, n₂)), n₁) == inv(CliffordOperator(sZCrY(n₁, n₂), n₁))
 @test CliffordOperator(inv(sInvZCrY(n₁, n₂)), n₁) == inv(CliffordOperator(sInvZCrY(n₁, n₂), n₁))
+ @test CliffordOperator(inv(sCXSWAP(n₁, n₂)), n₁) == inv(CliffordOperator(sInvSWAPCX(n₁, n₂), n₁))


Where does this come from?

CXSWAP: https://github.com/quantumlib/Stim/blob/main/doc/gates.md#CXSWAP

SWAPCX: https://github.com/quantumlib/Stim/blob/main/doc/gates.md#SWAPCX

I used the inv(CliffordOperator(...)) to find SWAPCX inverse. I saw that InvSWAPCX is the same as CXSWAP. So, I added a test for this relationship as well.

Krastanov · 2024-09-14T02:44:40Z

test/test_symcliff.jl

+ @testset "New two qubit gates consistency check" begin
+ # see https://github.com/quantumlib/Stim/blob/main/doc/gates.md
+ @test CliffordOperator(sSWAPCX) == C"IX XX ZZ ZI"
+ @test CliffordOperator(sInvSWAPCX) == C"XX XI IZ ZZ"


This does not seem to be in the linked list of gates. Where is it from?

SWAPCX: https://github.com/quantumlib/Stim/blob/main/doc/gates.md#SWAPCX

I used the inv(CliffordOperator(...)) to find it's inverse.

Krastanov · 2024-09-14T02:46:53Z

test/test_symcliff.jl

+ @test CliffordOperator(sSQRTZZ) == C"YZ ZY ZI IZ"
+ @test CliffordOperator(sInvSQRTZZ) == C"-YZ -ZY ZI IZ"


Where are these two coming from?

SQRTZZ: https://github.com/quantumlib/Stim/blob/main/doc/gates.md#SQRT_ZZ
SQRTZZDAG: https://github.com/quantumlib/Stim/blob/main/doc/gates.md#the-sqrt_zz_dag-gate

Krastanov · 2024-09-14T02:47:46Z

src/symbolic_cliffords.jl

+LinearAlgebra.inv(op::sSQRTZZ) = sInvSQRTZZ(op.q1, op.q2)
+LinearAlgebra.inv(op::sInvSQRTZZ) = sSQRTZZ(op.q1, op.q2)


repeated question: where are these two from

Please see: #336 (comment)

test/test_symcliff.jl

Co-authored-by: Stefan Krastanov <github.acc@krastanov.org>

Fe-r-oz · 2024-09-14T07:48:21Z

Hopefully, my comments were satisfactory. All the gate definitions are from stim gates page.

I think PR is ready for review, Thank you!

adding new types of two qubit SWAP gates

b2d1264

Krastanov requested changes Aug 10, 2024

View reviewed changes

Fe-r-oz marked this pull request as draft August 11, 2024 06:08

add wonderful codereview suggestions

e575303

Fe-r-oz marked this pull request as ready for review August 14, 2024 06:59

Fe-r-oz changed the title ~~adding new types of two qubit SWAP gates~~ adding all types of two qubit SWAP gates and sSQRTZZ/sInvSQRTZZ gate Aug 15, 2024

Fe-r-oz changed the title ~~adding all types of two qubit SWAP gates and sSQRTZZ/sInvSQRTZZ gate~~ adding all missing types of two qubit SWAP gates and sSQRTZZ/sInvSQRTZZ gate Aug 15, 2024

Add sISWAP, sInvISWAP completing all types of SWAP gates along with s…

fe3887d

…SQRTZZ and sInvSQRTZZ gates

Fe-r-oz force-pushed the new2qubitgates branch from b52f506 to fe3887d Compare August 15, 2024 16:21

Fe-r-oz requested a review from Krastanov August 18, 2024 08:50

Krastanov requested changes Sep 14, 2024

View reviewed changes

Update test/test_symcliff.jl

8e08979

Co-authored-by: Stefan Krastanov <github.acc@krastanov.org>

Fe-r-oz requested a review from Krastanov September 14, 2024 07:48

Merge branch 'QuantumSavory:master' into new2qubitgates

ab5726e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding all missing types of two qubit SWAP gates and sSQRTZZ/sInvSQRTZZ gate #336

adding all missing types of two qubit SWAP gates and sSQRTZZ/sInvSQRTZZ gate #336

Fe-r-oz commented Aug 7, 2024

codecov bot commented Aug 7, 2024

Krastanov left a comment

Fe-r-oz commented Aug 15, 2024 •

edited

Loading

Krastanov left a comment

Krastanov Sep 14, 2024

Fe-r-oz Sep 14, 2024

Krastanov Sep 14, 2024

Fe-r-oz Sep 14, 2024

Krastanov Sep 14, 2024

Fe-r-oz Sep 14, 2024

Krastanov Sep 14, 2024

Fe-r-oz Sep 14, 2024

Fe-r-oz commented Sep 14, 2024

		@test CliffordOperator(sSQRTZZ) == C"YZ ZY ZI IZ"
		@test CliffordOperator(sInvSQRTZZ) == C"-YZ -ZY ZI IZ"

		LinearAlgebra.inv(op::sSQRTZZ) = sInvSQRTZZ(op.q1, op.q2)
		LinearAlgebra.inv(op::sInvSQRTZZ) = sSQRTZZ(op.q1, op.q2)

adding all missing types of two qubit SWAP gates and sSQRTZZ/sInvSQRTZZ gate #336

Are you sure you want to change the base?

adding all missing types of two qubit SWAP gates and sSQRTZZ/sInvSQRTZZ gate #336

Conversation

Fe-r-oz commented Aug 7, 2024

codecov bot commented Aug 7, 2024

Codecov Report

Krastanov left a comment

Choose a reason for hiding this comment

Fe-r-oz commented Aug 15, 2024 • edited Loading

Krastanov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Fe-r-oz commented Sep 14, 2024

Fe-r-oz commented Aug 15, 2024 •

edited

Loading