Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noncliff: improvements to apply! and dictvaltype #346

Merged
merged 11 commits into from
Sep 27, 2024

Conversation

Fe-r-oz
Copy link
Contributor

@Fe-r-oz Fe-r-oz commented Aug 22, 2024

Improving dictvaltype and apply!.

If you want to submit an unfinished piece of work in order to get comments and discuss, please mark the pull request as a draft and ping the repository maintainer.

Please address only one topic or issue per pull request! Many small PRs are much easier to review and merge than one large PR.

Before merging, all changes and new functionality should be marked in the CHANGELOG file, but feel free to just leave your CHANGELOG notes in the PR description, to avoid merge conflicts with other requests modifying that file. The maintainer will add these CHANGELOG notes for you if you do so.

Before considering your pull request ready for review and merging make sure that all of the following are completed (please keep the clecklist as part of your PR):

  • The code is properly formatted and commented.
  • Substantial new functionality is documented within the docs.
  • All new functionality is tested.

If possible, keep your git history not too wild (rebase and squash commits, keep commits small and semantically separated) so that review is easier.

@Fe-r-oz
Copy link
Contributor Author

Fe-r-oz commented Aug 22, 2024

This pr implements a safe version of apply!

P.S. There is no ref[] due to which there was test error in non-cliff nonclifford quantum optics test branch. commented that out for a time being.

@Krastanov
Copy link
Member

Ah, this is great, much easier to work with! Thanks for setting it up this way. Now it is not even necessary to worry about squashing commits (mostly), because it is on top of another branch. Request a review whenever you feel it is ready.

Indeed, do not worry about the changelog check at all.

@Krastanov Krastanov added the Skip-Changelog label for control of CI: skips the changelog check label Aug 22, 2024
@Fe-r-oz
Copy link
Contributor Author

Fe-r-oz commented Aug 23, 2024

Please review!

@Krastanov
Copy link
Member

Hi, Feroz! Please be more careful with review requests -- here for instance you made a review request but then you continued making changes. It is better to wait a couple of days before making a review request to make sure you are done with your changes. Of course, this is not a big deal, especially if it happens just occasionally, however with your pull requests this is pretty common. Your contributions are appreciated, but reviewing is a significant investment of time, so I need to be selective when I start reviewing things.

@Fe-r-oz
Copy link
Contributor Author

Fe-r-oz commented Aug 23, 2024

Apologies for that. I really appreciate your time and your patience. Sorry for these annoying commits towards the very end.

@Fe-r-oz Fe-r-oz changed the title improvements to apply! and dictvaltype noncliff: improvements to apply! and dictvaltype Aug 30, 2024
Copy link
Member

@Krastanov Krastanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a good start. I left in some initial comments

test/test_nonclifford_quantumoptics.jl Outdated Show resolved Hide resolved
src/nonclifford.jl Outdated Show resolved Hide resolved
src/nonclifford.jl Outdated Show resolved Hide resolved
src/nonclifford.jl Outdated Show resolved Hide resolved
src/nonclifford.jl Outdated Show resolved Hide resolved
src/nonclifford.jl Outdated Show resolved Hide resolved
src/nonclifford.jl Outdated Show resolved Hide resolved
@Fe-r-oz
Copy link
Contributor Author

Fe-r-oz commented Sep 14, 2024

Thank you, addressed all of your comments. I think it's ready for review.

Copy link
Member

@Krastanov Krastanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! Some minor cosmetic things left.

src/nonclifford.jl Outdated Show resolved Hide resolved
src/nonclifford.jl Outdated Show resolved Hide resolved
src/nonclifford.jl Outdated Show resolved Hide resolved
@Fe-r-oz
Copy link
Contributor Author

Fe-r-oz commented Sep 15, 2024

Thank you for your suggestions. I think this is ready for review.

@Krastanov Krastanov merged commit 624eedd into QuantumSavory:nonclif Sep 27, 2024
10 of 12 checks passed
@Krastanov
Copy link
Member

Thanks!

@Fe-r-oz Fe-r-oz deleted the noncliff branch September 27, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog label for control of CI: skips the changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants