-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
better bit-wrangling abstraction using less boilerplate #367
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wonderful!
There are quite a few more places where this is used though:
- apply_noise.jl
- pauli_operator.jl
- project_trace_reset.jl
- QuantumClifford.jl
- symbolic_clifford.jl
Not all of them necessarily need to change, maybe what is done here is appropriate to only some for them.
While this is a big step towards fixing #113, I do not think it is sufficient to call it a fix. It is way less boilerplate, but it still has some amount of boilerplate. But we should merge it before worrying about improving it further -- this will already be pretty useful.
Thank you for highlighting all the files. I have carefully made the changes at appropriate places. Please do cross check them again as these bit masks are used in the critical places. Since I think the PR is ready for review. Thank you. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #367 +/- ##
==========================================
+ Coverage 82.42% 82.65% +0.23%
==========================================
Files 70 70
Lines 4580 4590 +10
==========================================
+ Hits 3775 3794 +19
+ Misses 805 796 -9 ☔ View full report in Codecov by Sentry. |
P.S. This will be beneficial for #411, as it streamlines several areas by reducing boilerplate code, including in |
Thanks, this is much neater! |
I have also checked that this does not introduce any JET errors. Hopefully, this is closes #113!