Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check_repr_commutation_relation to test the CSS orthogonality condition for 2BGA's Group Algebra with a General Group G #403

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

Fe-r-oz
Copy link
Contributor

@Fe-r-oz Fe-r-oz commented Oct 23, 2024

This PR implements the CSS orthogonality condition given by left and right representation matrix commutation relation of group algebra of the 2BGA code. This consistency check will be used in the tests PRs. This is inspired from insights from @thofma!

Given that we are use a rich set of groups in the tests PRs , this consistency test will be provide an additional crosscheck.

Edit:

Some details from literature

  • In a group algebra $\mathbb{F}[G]$, the left $L(a)$ and right $R(b)$ representations of elements commute:

    $$L(a) \cdot R(b) = R(b) \cdot L(a)$$

    This results from the associativity of multiplication.

The snapshot below talks about this in the following general way: Reference

  • In an algebra $R$, the left $\lambda_r$ and right $\rho_r$ regular matrix representations commute:

    $$\rho_a \lambda_b = \lambda_b \rho_a$$

    This follows from the associativity of multiplication in $R$.

Screenshot_select-area_20241024101141

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.82%. Comparing base (6a8dbb4) to head (dda1502).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
+ Coverage   83.08%   84.82%   +1.74%     
==========================================
  Files          70       71       +1     
  Lines        4410     5120     +710     
==========================================
+ Hits         3664     4343     +679     
- Misses        746      777      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fe-r-oz Fe-r-oz marked this pull request as ready for review October 24, 2024 03:56
@Fe-r-oz
Copy link
Contributor Author

Fe-r-oz commented Oct 24, 2024

@Krastanov, This PR is ready for review. Thanks! check_repr_commutation_relation will be used by the tests PRs to check the consistency of Group Algebra for 2BGA codes.

Copy link
Member

@Krastanov Krastanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks useful, thanks! I left a few questions below

src/ecc/ECC.jl Outdated
@@ -15,7 +15,7 @@ abstract type AbstractECC end

export parity_checks, parity_checks_x, parity_checks_z, iscss,
code_n, code_s, code_k, rate, distance,
isdegenerate, faults_matrix,
isdegenerate, faults_matrix, check_repr_commutation_relation,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not export it for now, just keep it as an internal check

@@ -46,6 +46,7 @@ other_lifted_product_codes = []
# [[882, 24, d≤24]] code from (B1) in Appendix B of [panteleev2021degenerate](@cite)
l = 63
GA = group_algebra(GF(2), abelian_group(l))
@test check_repr_commutation_relation(GA) == true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this check expected to be used anywhere else if merged?

Also, you do not need to do == true -- the result is already a boolean

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check will be used by all the tests PRs. Since we are extending the functionality to a finite general group via group presentation, usually non-abelian, this checks whether this commutation relation holds for such groups.

@Fe-r-oz
Copy link
Contributor Author

Fe-r-oz commented Oct 25, 2024

I have incorporated your suggestions, Thanks!

P.S A few misc cleanups were done: removed typo and moved the consistency check to ECC\codes\util.jl

@Fe-r-oz Fe-r-oz changed the title Check representation matrix commutation relation for the CSS orthogonality condition for 2BGA's Group Algebra add check_repr_commutation_relation to test the CSS orthogonality condition for 2BGA's Group Algebra with a General Group G Oct 26, 2024
@Krastanov Krastanov added the Skip-Changelog label for control of CI: skips the changelog check label Nov 5, 2024
@Krastanov Krastanov merged commit 5531336 into QuantumSavory:master Nov 5, 2024
16 of 19 checks passed
@Krastanov
Copy link
Member

thanks, this will be of great use throughout the tests

@Fe-r-oz Fe-r-oz deleted the fa/reprconsistency branch November 5, 2024 09:23
@Fe-r-oz Fe-r-oz restored the fa/reprconsistency branch November 5, 2024 09:24
@Fe-r-oz Fe-r-oz deleted the fa/reprconsistency branch November 5, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog label for control of CI: skips the changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants