Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HyperSpectra: use a preselected colormap for some SNOM data #757

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

markotoplak
Copy link
Collaborator

So, @borondics, this is ALMOST what you wanted: two specific kinds of data get their own color maps.

So what is wrong with it? For those two data types users can not then change colors. If I allowed that and used the datatype as a hint in changing the actual settings, that setting would also (it is how settings work) influence the future HyperSpectra instances. I could make some more complex logic around it so that the setting would not be saved unless the user then manually changed it, but that is more complex and if not done carefully, could introduce more problems than it would solve.

This is it for for now. Take it or leave it...

@borondics
Copy link
Member

borondics commented Oct 4, 2024

Hi @markotoplak, thanks for trying to add this quickly. I think with this condition that currently it is not possible to change the colormap for those files we should just leave it in the original version, so no preselection of the colormap for now.

Later, this could be an awesome feature too, but not so urgent.

@markotoplak markotoplak marked this pull request as draft October 4, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants