Details pane title shows node/rel caption instead #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QubitPi
force-pushed
the
details-pane-title
branch
from
bb32db8 to
6ec36db
Compare
QubitPi
changed the title
QubitPi
added a commit
that referenced
this pull request
Nov 27, 2023
* Details pane title shows node/rel caption instead * Add unit tests * Add E2E tests * Version bump version bump
QubitPi
added a commit
that referenced
this pull request
Dec 11, 2023
* Details pane title shows node/rel caption instead * Add unit tests * Add E2E tests * Version bump version bump
QubitPi
added a commit
that referenced
this pull request
Jun 11, 2024
* Details pane title shows node/rel caption instead * Add unit tests * Add E2E tests * Version bump version bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Added
Changed
Node inspector panel is showing not-so-useful title of "Node properties/Rel properties". It's better to display the node/rel caption there, which is what is PR do
A natural option is to apply the caption generation logic to the pane title section of the node inspection panel; a details inspection, however, realized that this would bring some of the graphing logics into the panel logic, which violated separation of concerns
So there is a technical obstacle which prevents this business requirement to become a reality
We would need to resolve this conflict by noticing that there are 3 options here:
The 3rd option immediately indicates some tiny refactoring hints below. We see the caption logic includes 2 parts: property selection and property rendering. The property selection can be naturally decoupled with graphing logic and be exported. Rendering the new title only requires knowing what property to display as text. **So our strategy is, to support this business requirement, separate the two logic into two methods and reuse one of the methods
Deprecated
Removed
Fixed
Security
Checklist
Reference