New Payment Window Design #131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramt
approved these changes
Nov 15, 2023
|
🎉 the pr is now 1 year old |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete redesign of the payment window, as well as clean-up of code and outdated templates.
The design is based on the one we're displaying on the front page of https://quickpay.net, though with some changes made for user friendliness - this being mainly keeping the footer with the language select at the bottom of the page as well as keeping the old "Cancel Payment" button.
New features
I have incorporated all PRs that have been merged while working on this new design into the branch, so everything should be up-to-date and ready for testing.
What needs to be done before deploying
Use of the payment window needs to be tested by people with fresh eyes and knowledge of the payment process.
After that, translations should be updated.
Testing
Testing involves checking that the layout looks all right and doesn't shift in weird ways when displaying the different templates.
I will be uploading this as a custom branding on Merchant 5 in production - named mlo-new-standard-branding - for testing of features difficult to access locally.
There will be scenarios I have overlooked, but here's a list of suggestions for testing the templates:
Overall layout:
Test on
Test the following layout states
Cards:
Payment Methods:
Other:
Feel free to inform me of bugs as soon as you notice them - rather than waiting until everything has been tested - so that I can get to work on fixing them immediately.