Changes to PayPal Button #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlouring
added a commit
that referenced
this pull request
Feb 7, 2024
jenssoren
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to be deployed together with https://github.com/QuickPay/payment/pull/1302
To work around PayPal's special requirements for how their button is loaded, we have had to make PayPal's HTML button container and CSS styling be slightly different to the ones for the other payment methods.
Since we're not able to apply the link to the entire container, there will be unclickable whitespace around the actual PayPal button, in order to make it align properly with the other buttons and fit the overall design as much as possible under the circumstances.
Unlike the other payment method buttons, this one will also have a fixed height. With our current button design, this should not cause problems, even if it's less than ideal for customers doing custom branding.