Merge pull request #225 from R-ArcGIS/remove-dplyr

refactor: remove dbplyr and dplyr integration
R-ArcGIS · Oct 17, 2024 · 68b3d45 · 68b3d45
2 parents 3ea9642 + 26bc0e6
commit 68b3d45
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 7 deletions.
diff --git a/.Rbuildignore b/.Rbuildignore
@@ -15,3 +15,4 @@
 ^cran-comments\.md$
 ^CRAN-SUBMISSION$
 ^README\.md$
+^R/dplyr-features\.R$
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: arcgislayers
 Type: Package
 Title: An Interface to ArcGIS Data Services
-Version: 0.3.1
+Version: 0.3.1.9000
 Authors@R: c(
     person("Josiah", "Parry", , "josiah.parry@gmail.com", role = c("aut", "cre"),
            comment = c(ORCID = "0000-0001-9910-865X")),

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,9 @@
+# arcgislayers (development version)
+
+## Breaking changes
+
+- `dplyr` methods for `collect()`, `select()`, and `filter()` have been removed. <https://github.com/R-ArcGIS/arcgislayers/issues/111> <https://github.com/R-ArcGIS/arcgislayers/issues/224> <https://github.com/R-ArcGIS/arcgislayers/issues/218>
+
 # arcgislayers 0.3.1
 
 ## Bug fixes

diff --git a/R/zzz.R b/R/zzz.R
@@ -25,11 +25,11 @@ s3_register <- function(pkg, generic, class, fun = NULL) {
 .onLoad <- function(...) {
   s3_register("sf", "st_crs", "FeatureLayer")
   s3_register("sf", "st_crs", "ImageServer")
-  s3_register("dplyr", "collect", "FeatureLayer")
-  s3_register("dplyr", "collect", "Table")
-  s3_register("dplyr", "filter", "Table")
-  s3_register("dplyr", "filter", "FeatureLayer")
-  s3_register("dplyr", "select", "FeatureLayer")
-  s3_register("dplyr", "select", "Table")
+  # s3_register("dplyr", "collect", "FeatureLayer")
+  # s3_register("dplyr", "collect", "Table")
+  # s3_register("dplyr", "filter", "Table")
+  # s3_register("dplyr", "filter", "FeatureLayer")
+  # s3_register("dplyr", "select", "FeatureLayer")
+  # s3_register("dplyr", "select", "Table")
 }