Add arc_read() (#108)
#118
Conversation
Also add more examples to `arc_read()`
|
holy smokes! Missed this! Will review |
|
This PR has conflicts with the man page of obj_check_layer and NEWS.md. Can you resolve the issues? Preferably this PR would have only modified the NAMESPACE and DESCRIPTION and created new files. |
|
@JosiahParry Happy to fix the conflicts. I was having trouble figuring out how to see where the conflicts were located. I need to get just a little bit better at Git + GitHub so I can figure out what to when I've already started on a PR and missed updates on the main repo. Probably should be using feature branches! If I should leave NEWS.md alone in the future, do you want to take it out of the PR checklist? Or is the intent for the checklist to be completed during review? |
|
Ah, yah, no, NEWS is totally fine to update too! The big conflicts come from documenting functions from outside of the scope of the PR. If you did all of this on main you may want to checkout a new branch with your code changes. Copy them somewhere else, then on main run git reset --hard to get the status of the main branch. Then, copy the relevant changed files onto a new branch. May be easiest to make a new PR instead of doing merge conflicts lol |
|
No rush to review, @JosiahParry, but I did want to confirm that I think the merge conflicts are resolved. |
|
Thank you for the reminder. Yes, merge conflicts are resolved! |
Also remove warning if n_max specifies fewer features than the max available
…t types. Adjust type checking to emit error for non-layer or image service types Skip tests on CRAN add addition tests for options, n_max, and unsupported types
|
I went and took the liberty of making some minor changes. I added a few tests as well as ensured that the function was robust against the wrong types. Gonna merge! If we dislike anything lets get it fixed in the next few weeks. Going to start working towards a CRAN release of arcgisutils next week. |
Checklist
devtools::document()devtools::check()passes locally (with the changes on main)Changes
Per #108, I added a
arc_read()function that works as a convenient alternative toarc_open()|>arc_select()and adds a col_names and name_repair parameter (an idea discussed briefly at #60 ) to provide a similar interface toreadr::read_delim()and other tidyverse read functions.The function documentation includes examples and the PR includes tests.
Follow up tasks
After this is added, it should likely be referenced in the README. If/when a getting started vigenette is added, it could also be documented there.