Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GroupLayer support per #120 #123

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Add GroupLayer support per #120 #123

merged 3 commits into from
Dec 27, 2023

Conversation

JosiahParry
Copy link
Collaborator

@JosiahParry JosiahParry commented Dec 27, 2023 •
edited
Loading

Checklist

  • update NEWS.md
  • documentation updated with devtools::document()
  • devtools::check() passes locally

Changes

  • adds GroupLayer class constructed in arc_open()
  • arc_open() now errors instead of returning NULL when the class isnt matched
  • get_layer(), get_layers() and get_all_layers() are now S3 generics where the default method is used for FeatureServers and MapServers
  • modify skip() messages for to be consistent
  • add tests for GroupLayers in arc_open()
  • create test files for get_layer(), get_layers(), and get_all_layers()
    Issues that this closes

Please link any issues that are closed by this PR

Closes #120

@JosiahParry JosiahParry marked this pull request as ready for review December 27, 2023 22:08
@JosiahParry JosiahParry merged commit 203bbbc into main Dec 27, 2023
7 checks passed
@JosiahParry JosiahParry deleted the grouplayers branch September 26, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Group Layer support to arc_open()
1 participant
@JosiahParry