use arc_token() to handle empty tokens

[kbvernon]

Checklist

• update NEWS.md
• documentation updated with devtools::document()
• devtools::check() passes locally

Changes

When "ARCGIS_TOKEN" is an empty string, it will sometimes cause HTTP 498 "invalid token" error. Need to NULL the empty string to handle this.

Issues that this closes

No issue opened here. See R-ArcGIS/arcgisutils#5.

Follow up tasks

Waiting for R-ArcGIS/arcgisutils#6 to be merged first.

[kbvernon]

May have jumped the gun not running devtools::document() first. Hopefully, that doesn't cause any issues. devtools::check() is going to break until the {arcgisutils} PR gets merged.

[JosiahParry]

We need to bump the minimum version of arcgisutils to 0.1.1.9000 to ensure compatibility. Can you change the minimum version? That should also get CI to download the correct version of arcgisutils.

[kbvernon]

Can do, but is there a programmatic way to do that, maybe with {usethis}, or do I just go in and edit the DESCRIPTION by hand?

[JosiahParry]

Yup! usethis::use_package("arcgisutils", min_version = "0.1.1.9000")

[JosiahParry]

@kbvernon can you remove this portion here? It's causing R CMD Check to fail because it was single handedly handling this bug. But now it should be working without this conditional.

arcgislayers/R/get-estimates.R

Lines 39 to 51 in 203bbbc

	if (token != "") {
	req <-
	httr2::req_auth_bearer_token(
	httr2::req_url_query(est_req, f = "json"),
	token
	)
	resp <- httr2::req_perform(req)
	} else {
	resp <-
	httr2::req_perform(
	httr2::req_url_query(est_req, f = "json")
	)
	}

[kbvernon]

ha, it appears this issue has come up before...

edit: which you said in that last comment, but i was too thick to register

[kbvernon]

it appears i chopped out that code uncritically, let me replace it with what needs to go there

[kbvernon]

devtools::check() just ran without error on my local machine, hopefully it passes here, too

[JosiahParry]

We'll make a package dev of you yet!