Release 2.4.0 #434
Merged
Release 2.4.0 #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mpgxvii
commented
Jun 23, 2023
•
mpgxvii
commented
- Cache questionnaires and standardize Github client access (Cache questionnaires and standardize github client access #432)
- Set upper limit of ttl to 28 days otherwise messages are not sent (https://firebase.google.com/docs/cloud-messaging/concept-options#:~:text=On%20Android%20and%20Web%2FJavaScript,attempts%20to%20deliver%20the%20message)
- Use async processing to avoid database timeouts (Use async processing to avoid database timeouts #437)
- Remove unused spring-data-rest dependency (Remove unused spring-data-rest dependency #440)
Fix CORS configs
- Use GithubClient inside GithubProtocolFetcherStrategy to improve readability and remove deplication. - Use GithubService as a proxy for GithubClient in endpoint. This caches any values from the questionnaire. - Created FunctionCache that caches the result of a throwing function for a given amount of time. - Added more checks on the request being performed: number of bytes for content length, more strict URL validation (only https://api.github.com is allowed now instead of for example http://api.github.com.my.domain.
Cache questionnaires and standardize github client access
Sync release with dev
Closed
HTTP/1.1 does less connection sharing, causing the requests to go through without connection resets.
In the previous handling of events, event were handled immediately during the transaction, in the same thread. This caused a lot of delays, blocking the database threads. The EventListener annotations are replaced by TransactionalEventListener to ensure that the previous transaction has been committed before processing the event. It explicitly creates a new transaction to avoid overlapping transactions. Finally, it enables async processing to avoid the existing transaction threads being blocked.
Remove unused spring-data-rest dependency
yatharthranjan
approved these changes
Oct 9, 2023
Use async processing to avoid database timeouts
@yatharthranjan Yes, but I want to include some changes before releasing: #443 |
Update release with latest changes
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.