Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UserMetrics and User cyclic dependency #446

Merged
merged 2 commits into from
Oct 21, 2023
Merged

Fix UserMetrics and User cyclic dependency #446

merged 2 commits into from
Oct 21, 2023

Conversation

mpgxvii
Copy link
Member

@mpgxvii mpgxvii commented Oct 20, 2023

  • Fix UserMetrics and User cyclic dependency

Solves #445

blootsvoets
blootsvoets reviewed Oct 20, 2023
View reviewed changes
Copy link
Member

@blootsvoets blootsvoets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Perhaps the column user_metrics.user_id should also be dropped?

@mpgxvii mpgxvii merged commit 25e6b46 into dev Oct 21, 2023
6 checks passed
@mpgxvii mpgxvii deleted the fix-user-metrics branch October 21, 2023 13:02
@mpgxvii mpgxvii mentioned this pull request Oct 23, 2023
Merged
@mpgxvii mpgxvii mentioned this pull request Mar 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blootsvoets blootsvoets blootsvoets left review comments

@yatharthranjan yatharthranjan Awaiting requested review from yatharthranjan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpgxvii @blootsvoets