Replaced MEASUREMENT.CREATE permissions #454
Conversation
| permission = AuthPermissions.CREATE, | ||
| entity = AuthEntities.MEASUREMENT, | ||
| permission = AuthPermissions.UPDATE, | ||
| entity = AuthEntities.PROJECT, |
There was a problem hiding this comment.
I think this should be permission = AuthPermissions.READ and inside the function we can check if the user has permission on the project like like: https://github.com/RADAR-base/RADAR-Appserver/pull/454/files#diff-1e80e358e3364d4b93b1aa06498dedf1686f827ff9bca66eb31b0164b72d3ca8R170
Because I don't think aRMT has PROJECT.UPDATE permissions. What do you think @yatharthranjan?
There was a problem hiding this comment.
I think we usually check SUBJECT.UPDATE on the PROJECT (since even the projects in appserver are created by participant tokens)
There was a problem hiding this comment.
Hi, I've updated the permissions to SUBJECT.UPDATE and I also updated the authorization code inside the function as Pauline suggested. Please let me know if any changes are needed.
Fixes: #317
Hi @yatharthranjan, could you please review this PR and let me know if any changes are needed?