Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 'users' unique constraints #469

Merged
merged 4 commits into from
May 24, 2024
Merged

Update 'users' unique constraints #469

merged 4 commits into from
May 24, 2024

Conversation

mpgxvii
Copy link
Member

@mpgxvii mpgxvii commented May 22, 2024 •
edited
Loading

  • Update users entity and table unique constraints
  • Make subject_id and project_id columns unique

Solves #468

@mpgxvii mpgxvii changed the base branch from release-2.4.2 to dev May 22, 2024 18:03
yatharthranjan
yatharthranjan reviewed May 24, 2024
View reviewed changes
...ain/resources/db/changelog/changes/00000000000002_update_schema-20240522185927_changelog.yml Outdated
changes:
- addUniqueConstraint:
columnNames: subject_id, project_id
constraintName: UK_subject_project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can maybe make this a bit more unique to avoid clashes (like adding timestamp at the end or a random string)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes made the changes.

yatharthranjan
yatharthranjan approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@yatharthranjan yatharthranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Btw did we find this happening in our deployments too? given that we check for this in the service method.

@mpgxvii
Copy link
Member Author

mpgxvii commented May 24, 2024

LGTM.

Btw did we find this happening in our deployments too? given that we check for this in the service method.

Yeah this is happening in our deployment. And only on the STAGING_PROJECT as well.

@mpgxvii mpgxvii merged commit b722d22 into dev May 24, 2024
4 checks passed
@yatharthranjan yatharthranjan deleted the fix/users branch June 3, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yatharthranjan yatharthranjan yatharthranjan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpgxvii @yatharthranjan