Skip to content

Commit

Permalink
Changed isService assertion in phone_call to number length
Browse files Browse the repository at this point in the history
  • Loading branch information
blootsvoets committed Jul 17, 2017
1 parent fe354d0 commit f058f25
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion commons/phone/phone_call.avsc
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
{"name": "duration", "type": "float", "doc": "duration of the call (s)", "default": "NaN"},
{"name": "target", "type": ["null", "bytes"], "doc": "HMAC SHA-256 one-way source/target of the call. This hash of a given phone number will be the same unless the app is reinstalled. If the number is unknown or anonymous, this contains null.", "default": null},
{"name": "type", "type": {"name": "PhoneCallType", "type": "enum", "symbols": ["INCOMING", "OUTGOING", "MISSED", "VOICEMAIL", "UNKNOWN"]}, "doc": "direction of phone call", "default": "UNKNOWN"},
{"name": "targetIsContact", "type": ["null","boolean"], "doc": "call to/from a known contact, null if unknown", "default": null}
{"name": "targetIsContact", "type": ["null","boolean"], "doc": "call to/from a known contact, null if unknown", "default": null},
{"name": "targetIsNonNumeric", "type": "boolean", "doc": "sms sender ID is replaced by text, e.g. a company name", "default": false},
{"name": "targetLength", "type": "int", "doc": "length of the target phone number, -1 if not collected.", "default": -1}
]
}
2 changes: 1 addition & 1 deletion commons/phone/phone_sms.avsc
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@
{"name": "length", "type": ["null","int"], "doc": "number of characters in the message (null if unknown)", "default": null},
{"name": "targetIsContact", "type": ["null","boolean"], "doc": "sms sender is a known contact, null if unknown", "default": null},
{"name": "targetIsNonNumeric", "type": "boolean", "doc": "sms sender ID is replaced by text, e.g. a company name", "default": false},
{"name": "targetIsService", "type": "boolean", "doc": "target is a service, e.g. a 4-digit target", "default": false}
{"name": "targetLength", "type": "int", "doc": "length of the target phone number, -1 if not collected.", "default": -1}
]
}

0 comments on commit f058f25

Please sign in to comment.