Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added schemas for Google activity recognition API. #344

Merged
merged 4 commits into from
Jul 19, 2023
Merged

Added schemas for Google activity recognition API. #344

merged 4 commits into from
Jul 19, 2023

Conversation

this-Aditya
Copy link
Member

Changes:

  • Added google_activity_recognition_event schema.
  • Created specification android_google_api_1.0.0, included specifications for activity_transition_events.

Fixes issue #337

blootsvoets
blootsvoets reviewed Jul 6, 2023
View reviewed changes
Copy link
Member

@blootsvoets blootsvoets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just change the specification file name please.

specifications/passive/android_google_api-1.0.0.yml Outdated Show resolved Hide resolved
@this-Aditya this-Aditya changed the base branch from master to dev July 6, 2023 09:43
@mpgxvii mpgxvii self-requested a review July 19, 2023 09:57
mpgxvii
mpgxvii approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@mpgxvii mpgxvii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the updates.

@mpgxvii mpgxvii merged commit fd07e4a into RADAR-base:dev Jul 19, 2023
2 checks passed
@this-Aditya this-Aditya deleted the google-activity branch July 20, 2023 10:08
@mpgxvii mpgxvii mentioned this pull request Oct 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blootsvoets blootsvoets blootsvoets left review comments

@mpgxvii mpgxvii mpgxvii approved these changes

@yatharthranjan yatharthranjan Awaiting requested review from yatharthranjan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@this-Aditya @blootsvoets @mpgxvii